Improve chat rule list & chat rule GUIs#2333
Conversation
LJNeon
force-pushed
the
chat-rules-ui
branch
3 times, most recently
from
27bac0a to
7ff9b2b
Compare
LifeIsAParadox
added
reviews needed
Alex33856
left a comment
Alex33856
left a comment
There was a problem hiding this comment.
forgot to click request changes
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
There was a problem hiding this comment.
if you want, you can make children a List<AbstractWidget> and add nameWidget to it, so you can just do children.forEach(child -> child.extractRenderState(graphics, mouseX, mouseY, a)); in extractContent.
There was a problem hiding this comment.
(which would save 0 lines of code because of the import 💀)
LifeIsAParadox
added
merge me please
viciscat
left a comment
viciscat
left a comment
There was a problem hiding this comment.
Sorry for late response didn't see. Still not a fan of the checkboxes, feels like it leaves too much empty space but I don't really care, if ya all think it's better then we shall go with em
Where exactly? Do you mean the checkboxes in the chat rule list? If so I could try to give more space to the other items to even that out...? Or if you have any other suggestions on how to make it look nicer to you. |
|
I meant in rule config screen, but it's fine, just gotta get used to it :p |
* Improve chat rule list & chat rule GUIs * Various fixes & wording tweaks (cherry picked from commit cbf4f9c)
5 participants
Chat rule list UI utilizes checkboxes instead of yes/no buttons and makes rule names scrollable when they are too long.
Chat rule list preview
Chat rule configuration UI utilizes checkboxes instead of yes/no buttons and has a link to a helpful resource for learning and testing regex.
Chat rule config preview
Helpful resource link preview
Note: Any and all feedback (even personal taste or nitpicks) is highly appreciated.